[
https://issues.apache.org/jira/browse/HIVE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207998#comment-16207998
]
Alan Gates commented on HIVE-17425:
-----------------------------------
Except for MetastoreConf tests, this set of calls in Metrics is the only place
it reaches under and uses conf.get rather than MetastoreConf.getVar. The
reason it does this is to avoid getting the default value (as noted in the
comments). In this case I don't want all the magic around checking various
options for MetastoreConf and HiveConf and defaults. It seems better to have
this one exception rather than add methods to MetastoreConf that could do this
automatically but that would confuse other developers as to which MetastoreConf
method they should be using.
> Change MetastoreConf.ConfVars internal members to be private
> ------------------------------------------------------------
>
> Key: HIVE-17425
> URL: https://issues.apache.org/jira/browse/HIVE-17425
> Project: Hive
> Issue Type: Task
> Components: Metastore
> Affects Versions: 3.0.0
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: HIVE-17425.patch
>
>
> MetastoreConf's dual use of metastore keys and Hive keys is causing confusion
> for developers. We should make the relevant members private and provide
> getter methods with comments on when it is appropriate to use them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
