[
https://issues.apache.org/jira/browse/HIVE-17425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215854#comment-16215854
]
Vihang Karajgaonkar commented on HIVE-17425:
--------------------------------------------
Thanks [~alangates] for the explanation related to {{Metrics}} class use-case.
It seems like we are doing it this way because we want to fall back to two
different hive config names if it is not defined, unlike most other cases when
there is only one hive config name to fall back too. It may be okay for now,
but I think we may need to add support to fall-back to multiple hive varnames
as more and more configurations in Hive get deprecated and new ones are
introduced instead of them.
For now, the patch looks good +1
> Change MetastoreConf.ConfVars internal members to be private
> ------------------------------------------------------------
>
> Key: HIVE-17425
> URL: https://issues.apache.org/jira/browse/HIVE-17425
> Project: Hive
> Issue Type: Task
> Components: Metastore
> Affects Versions: 3.0.0
> Reporter: Alan Gates
> Assignee: Alan Gates
> Attachments: HIVE-17425.2.patch, HIVE-17425.patch
>
>
> MetastoreConf's dual use of metastore keys and Hive keys is causing confusion
> for developers. We should make the relevant members private and provide
> getter methods with comments on when it is appropriate to use them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
