Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/87
> What -tol did is to compare the absolute difference between the last and
current cumulative loss; that is, the initial implementation checked
convergence based on absolute difference. Meanwhile, -cv_rate looks relative
difference. Hence, in a precise sense, your commit feb9bb1 is not "refactor,"
and I need to find a completely different optimal combination of
hyper-parameters for testing.
`absolute difference => relative difference` DOES NOT explain too large
loss in the middle of iterations. Even without conversion checks, it was never
converged.
Iterations were converged when using absolute difference and
`Assert.assertTrue(cumLoss / samplesList.size() < 0.5d);` was passing. Why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
