bamaer opened a new pull request, #7685: URL: https://github.com/apache/hop/pull/7685
The Error path tab never showed the action that actually failed: - The workflow logging wrote every counter of an action except the error count, so a failed action never satisfied "err.errors > 0". The parameter was already being filled in, it just wasn't set on the node. Pipelines and transforms already logged theirs. - The lookup used size() on a pattern expression, which Neo4j 5 removed, so the query failed outright against Neo4j 5. Replaced with a pattern predicate, which works on both Neo4j 4 and 5. Also in the perspective: - Read strings through LoggingCore instead of Value.asString(), which returns the literal text "null" for a property that isn't set and so slipped past Const.NVL(). - Tell the user what happened when Open finds no file behind an execution, instead of leaving the button without any effect. Adds unit tests for the generated Cypher, an integration test which runs the lookup against a Neo4j 5 container, and a Hop integration test under integration-tests/neo4j. The container test is skipped automatically when no Docker daemon is available. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
