vbhanuchander-lang commented on PR #7747: URL: https://github.com/apache/hop/pull/7747#issuecomment-5152799534
Thanks for the review and for running the suite, @mattcasters! I've pushed an integration test as `0004-kafka-test-topic-from-field`. It publishes two rows through a single Kafka Producer, each naming its own topic in a field (`hop-test-topic-a` and `hop-test-topic-b`), then consumes only topic A. The check asserts both that topic A's message arrives **and** that topic B's does not. Asserting only the first would still pass if the producer ignored the field and sent every row to one topic, which is the regression actually worth catching. For the same reason the static topic is set to `hop-test-unused-fallback` — a row that skipped the field lands somewhere nothing reads, so the assertion fails loudly rather than passing by accident. It reuses `0001-kafka-consumer-called-subpipeline.hpl` rather than adding a fourth copy, since it's a plain injector over the standard Kafka output fields with nothing test specific in it. Happy to give 0004 its own copy if you'd rather each test stayed fully self-contained. Local run of `./run-tests-docker.sh PROJECT_NAME=kafka`: ``` PASSED 0001-kafka-test-basic (6.973s) PASSED 0002-kafka-test-mapping (6.280s) PASSED 0003-kafka-test-stop-when-idle (6.262s) PASSED 0004-kafka-test-topic-from-field (5.403s) PASSED HOP3504-kafka-test-error-path (1.120s) kafka: 5 passed, 0 failed, 0 skipped ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
