budaykiran94 opened a new pull request, #8025: URL: https://github.com/apache/hop/pull/8025
Fixes the input-stream validation in the four Salesforce output transforms. `SalesforceInsertMeta`, `SalesforceUpdateMeta`, `SalesforceUpsertMeta` and `SalesforceDeleteMeta` reported `TYPE_RESULT_ERROR` when the transform had incoming hops, and `TYPE_RESULT_OK` when it had none. All four are `Category.Output` transforms that consume rows via `getRow()` in `processRow()`, so they cannot function without input — the condition was inverted. The message keys in use (`CheckResult.NoInputExpected` / `CheckResult.NoInput`) belong to an input transform, which suggests the block was copied from `SalesforceInputMeta`. The error text shown to users read "This transform is not expecting nor reading any input", which is not true of these transforms. The check now follows the convention used by `TableOutputMeta`: `ExpectedInputOk` when input is present, `ExpectedInputError` when it is absent. **Notes on scope:** - `SalesforceInputMeta` is deliberately unchanged — its check is correct for an input transform. - Only `en_US` messages are updated; translated locales are left to the i18n process. - The `testCheck` assertions in the four corresponding test classes encoded the same inverted expectation (they called `check()` with a null `input` and asserted no error). They now pass an input array when checking a fully configured transform. The first assertion in each test, which checks an unconfigured transform, is unchanged. **How to verify:** `mvn test -pl plugins/tech/salesforce` — 261 tests pass. In the GUI: wire any input transform into a Salesforce Insert transform and run "Check pipeline". Before the fix an error is reported; after, the check passes. Fixes #8024 **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
