mattcasters commented on PR #8329:
URL: https://github.com/apache/hop/pull/8329#issuecomment-5636925473
Thanks Bart — all four points addressed in a63ea952de.
**1. Error hops.** `PipelineMeta.findPreviousMainTransforms()` is the shared
helper: enabled hops only, not info, not error. Verify
(`addUnconsumedMainInputRemark`), `init()`, leftover `setOutputDone()`, and
`hasUnreadMainInput()` all go through it. `findPreviousTransforms(to, false)`
still includes error-hop predecessors (unchanged, used by field layout). Tests
now run against a real `PipelineMeta`
(`findPreviousMainTransformsExcludesErrorHops`,
`checkTransformsAllowsErrorHopIntoNonConsumer`,
`initAllowsErrorHopIntoNonConsumer`).
**2. Hop presence vs leftover rows.** Kept the hard fail on hop presence —
that's the hang we are actually fixing, and a zero-row upstream is still a
graph that will stall the moment it starts producing. Opt-out for existing
files: set `HOP_ALLOW_UNCONSUMED_MAIN_INPUT=Y` on the run (`@Variable`,
configuration perspective, `variables.adoc`, pipeline-sources). That skips both
the `init()` failure and the leftover `stopAll()`. Verify still reports the
error either way. Messages name the variable (quoted so `MessageFormat` does
not treat `{HOP_...}` as a placeholder).
**3.** `logDisallowedMainInput()` now does `setErrors(getErrors() + 1)`.
Covered by the leftover test starting from a non-zero count.
**4.** `isPipelineSourceAtDefault()` still `loadClass()`s (needed for the
instance methods) but no longer calls `setDefault()`. Field defaults match a
transform just dropped on the canvas; LDAP-style `setDefault()` work stays off
the add-transform dialog path.
Engine module: 1030 tests, 0 failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
