bamaer opened a new issue, #8391:
URL: https://github.com/apache/hop/issues/8391
### What needs to happen?
### 1. `hop-web.adoc` contradicts current behaviour
`docs/hop-user-manual/modules/ROOT/pages/hop-gui/hop-web.adoc:178` still
says that
in mode `NONE`, `/hop/*` is unauthenticated "just like `/ui`". `/hop/*` is
now
closed by default; `/ui` remains open.
- [ ] Correct the mode `NONE` description
- [ ] Document `allowUnauthenticatedServerApi` /
`HOP_WEB_ALLOW_UNAUTHENTICATED_SERVER_API`
as the opt-in for running Hop Web as an execution server behind
network controls
- [ ] State that `/ui` stays open in mode `NONE` by design
### 2. `THREAT_MODEL.md` does not cover hop-web as a deployment
`THREAT_MODEL.md:57` calls `rap/` "the web GUI, not a server", but the
artifact from
`assemblies/web` co-deploys `HopServerServlet` on `/hop/*` and
`HopApiApplication`
on `/hop/api/v1/*`. `THREAT_MODEL.md:145-146` scopes default Basic auth
(`enable_auth`) to `hop-server`; hop-web has no equivalent and ships in mode
`NONE`.
- [ ] Add hop-web as a distinct deployment, separate from `rap/` and
`hop-server`
- [ ] Scope the `enable_auth` assumption to `hop-server` explicitly
- [ ] Describe the hop-web boundary: `/ui` open in `NONE`, `/hop/*`
default-denied,
`BASIC`/`OAUTH2` filters on `/*`, `EXTERNAL` delegating to the
container
### 3. `EXTERNAL` mode fails open without feedback
Nothing in `rap/` enforces `EXTERNAL` — it relies entirely on a container
`<security-constraint>`, which the shipped `web.xml` does not contain. An
operator
who selects `EXTERNAL` without adding it gets an unrestricted `/ui` while
believing
authentication is enabled. `/hop/*` still returns 401, and the Security tab
shows
the contradiction, but nothing is logged.
- [ ] In `HopWebEntryPoint` (currently logging "no authenticated principal"
at debug,
lines 162-164), log at `WARNING` when a request arrives with no
principal in a
mode other than `NONE`
### Issue Priority
Priority: 2
### Issue Component
Component: Hop Web
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
