leehaut commented on PR #8354: URL: https://github.com/apache/hop/pull/8354#issuecomment-5706732579
Sorry, I should have linked an issue and made the reason clearer in the PR description. There is no existing GitHub issue; this came from an internal code review of Sorted Merge, not a user-reported pipeline failure. The old comparator caught HopValueException and returned 0 (there was even a TODO about whether to fail instead). In a Comparator, 0 means the rows are equal, so a failed key compare was treated as a tie during sort/binarySearch. The k-way merge could then emit rows out of order with no error and no log. This PR: 1. Fails the transform with HopRuntimeException when comparison throws, instead of returning 0. 2. Makes SortedMergeMeta.getFields() set sortedDescending the same way as runtime and Sort Rows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
