leehaut opened a new pull request, #8354:
URL: https://github.com/apache/hop/pull/8354

   ## Summary
   - Sorted Merge no longer treats a failed key comparison as equality. A 
`HopValueException` from the comparator now fails the transform with 
`HopRuntimeException` instead of `return 0`, which previously could silently 
emit rows out of order.
   - `SortedMergeMeta.getFields()` now sets `sortedDescending` to match runtime 
and Sort Rows (`setSortedDescending(!isAscending())`).
   - Add unit coverage for merge, comparison failures, metadata checks, and 
`RowSetRow`; replace `RowSetRow` getters/setters with Lombok.
   
   ## Test plan
   - [x] `plugins/transforms/sortedmerge` unit tests (`SortedMergeTest`, 
`SortedMergeMetaTest`, `RowSetRowTest`)
   - [x] Existing integration pipeline 
`integration-tests/transforms/0102-sorted-merge-multi-copy.hpl` still merges 
sorted String streams correctly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to