rmannibucau commented on PR #8304: URL: https://github.com/apache/hop/pull/8304#issuecomment-5714722722
the goal is really the parity without the cost to create workbook, xml still etc. that said the failure case is guarded with the system property, so the workaround is quick to spot and ack we should highlight this change in the changelog. one thing to highlight is that it is not worse than the migration script from pentaho which use this transform, they have the same pitfalls and a big performance degradation so maybe in next minor (not patch) but think a variable wouldn't be a good move since we don't want the impl to be picked but to be auto optimized on the long run so it shouldnt be exposed IMHO. /me will check the other diff now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
