rmannibucau commented on PR #8304: URL: https://github.com/apache/hop/pull/8304#issuecomment-5720155277
> We have hundreds of integration tests in the [integration-tests](https://github.com/apache/hop/tree/main/integration-tests) folder. These are Apache Hop pipelines and workflows to test Apache Hop functionality. These have already uncovered tons of bugs that slipped through the cracks in code-based tests and have prevented numerous regressions. well there it is super localized and 100% computation related so think the test of this PR is more than covering the change, no? there is no real way to discover something you didnt spot without the UI using the UI, would just be slower. Do you have something specific in mind? @hansva my issue with competing solutions is that it is hard to have a proper communication to end users and it promotes repeated migrations or a fragmented ecosystem, both are negative on user end side (even if I get the core issues it solves but on my side I care more of end users than core challenges). This is why making it an implementation details is good IMHO. Also using excel syntax got proven interesting since hop is about UI and no-code at some extent so it is more friendly for end users, it is just too slow today. @mattcasters think bringing the component and flagging it "PDI compatibility" somehow (likely in the name and migration tool) would be super beneficial. Remains the question of the main promoted formula component outside the migration scope. I also had another idea, maybe a bit more crazy but worth giving a try since it shouldn't be too much work (but not 100% sure it pays as much): just implementing an excel-file-less formula evaluator in Apache POI si Apache hop gets it almost for free. Will try to give it a try and report there - at least to say "it was literally too crazy" if it didnt go anywhere to avoid another one to give a try later on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
