leehaut opened a new pull request, #8502: URL: https://github.com/apache/hop/pull/8502
Fix https://github.com/apache/hop/issues/8500 ## Summary - CSV Input Verify (F7) no longer treats an incoming hop as an error. That matches the dialog and runtime: a previous transform means the filename comes from a field. - In filename-from-field mode, check that the filename field is set and exists in the previous row meta. - In static filename mode, report an error when no filename is specified (same condition as `CsvInput.init()`). - Split `CsvInputMeta.check()` into helpers so cognitive complexity stays under the Sonar limit. ## Test plan - [x] Filename from field: Generate rows → CSV Input, filename field set to a real upstream field. F7 should be OK (no “receiving input” ERROR). - [x] Filename from field: hop present but filename field empty, or field name not in previous fields. F7 should ERROR. - [x] Static filename: CSV Input with no incoming hop and a file path set. F7 should be OK. - [x] Static filename: no incoming hop and filename empty. F7 should ERROR with “No filename is specified to read from.” - [x] Downstream hop only (CSV Input → Write to log) still uses static filename mode. - [x] `CsvInputMetaTest` check cases pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
