mattcasters opened a new pull request, #8602: URL: https://github.com/apache/hop/pull/8602
Double-clicking a workflow in the execution perspective crashed before the viewer opened. `ExecutionPerspective.setActiveViewer` called `CTabItem.getData().equals(viewer)`, so a tab that had never received its viewer threw a `NullPointerException` and the error dialog replaced the workflow. Tab lookup now skips a tab with no data, restores data when the tab is still showing that viewer, and opens a new viewer when a registration has no tab. A new tab stores its viewer before the title or control is attached, and a failed open discards the half-built tab. Refreshing a workflow skips an action that has no sample data yet, so one missing child does not fail the whole info panel. fixes #8601 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
