bamaer opened a new pull request, #8630: URL: https://github.com/apache/hop/pull/8630
…empty Every pgvector search filter became "column = ?", so a row whose filter field was null or empty matched nothing and quietly returned no results. Filters get a "Skip if empty" option (skip_if_empty, default N, so existing pipelines are unchanged). When set, that filter is left out of the WHERE clause for rows where its value is empty. It is per filter so required filters, such as a tenant or access-control column, keep applying and can never widen a search. Each combination of active filters gets its own prepared statement, created on first use and cached, which keeps plain equality predicates. The statement with every filter is still prepared up front, so a bad table or column name fails on the first row as before. Also document which settings win when Language Model Chat uses an AI Provider: the provider's type, base URL, API key, chat model, timeout and temperature override the inline values, which are only fallbacks for empty provider fields. Correct the AI Provider page, which said the transform can override the model; that holds for the embedding transforms, not for Language Model Chat. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
