mattcasters commented on PR #8560: URL: https://github.com/apache/hop/pull/8560#issuecomment-5847788129
Thanks for the review. Addressed in 6c3a232c4d. 1. and 2. Start and debug use `!isRunning()` again. A successful Beam run and a failed preparation never set finished, so that check blocked the next Run. The session guard is what keeps a stale listener off the new timers. 3. and 5. `checkPipelineEnded`, `pipelineFinished`, and the workflow equivalents run before the session lock is taken. Only `stopRedrawTimer()` stays inside `stopIfCurrent`, and it does not take the graph lock or open a dialog. 4. Removed `setClearingMetricsPerIteration(false)`. Nothing called `buildExecutionSummary()` after the Kafka call went away, so the flag and that method are deleted. Sub-pipeline counters are no longer cleared because nothing wipes them. 6. `scheduleWhileCurrent` cancels the timer on the first tick that sees a newer engine. Pipeline and workflow redraw, and the metrics grid, all go through it. The workflow listeners are registered before the execution thread and the redraw timer. `adopt` returns the engine and generation together. The first-row date is set once per batch, before the record loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
