mattcasters opened a new pull request, #8560: URL: https://github.com/apache/hop/pull/8560
## Summary Fixes #8546. Stopping a pipeline sets the stopped flag before the engine has finished. For a Kafka consumer that window is long enough to start again while the previous engine is still leaving `poll()`. The previous engine's finished listener then stopped the canvas and metrics timers of the run now on screen. Batches kept showing up in the log, and the grid stayed at 0 until the next stop refreshed it once. The Kafka batch log made that look like a metrics bug of its own. `Finished processing (I=…, R=…, W=…)` is one sub-pipeline iteration, and those counters were cleared immediately afterwards when no execution information location was set. `Number of rows read` was the injector buffer size, not a grid metric. The parent transform only increments Input. - Refresh timers are bound to the engine currently shown. A finished or stopped listener from the previous pipeline or workflow cannot stop the new run. - Start is refused until the previous pipeline has finished, using the existing "do not start twice" dialog. `isRunning()` is unchanged, so the toolbar behavior is the same. - The Kafka consumer keeps cumulative sub-pipeline metrics and logs `Kafka consumer batch of N record(s), cumulative input M`. Read and Written on the Kafka transform stay 0 unless result fields are mapped back. Mapping and Beam still clear counters per iteration. ## Test plan - [x] `./mvnw -pl ui test -Dtest=ExecutionGuiSessionTest` - [x] `./mvnw -pl plugins/transforms/kafka -am test -Dtest=KafkaConsumerInputTest -Dsurefire.failIfNoSpecifiedTests=false` - [ ] Stop a running Kafka consumer, start it again before the first engine has fully exited, and confirm Input keeps increasing while batches are logged - [ ] Drill into the running sub-pipeline and confirm its transform metrics accumulate instead of returning to 0 after each batch - [ ] Stop and restart a workflow with a slow action and confirm the canvas keeps redrawing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
