bamaer commented on code in PR #8590:
URL: https://github.com/apache/hop/pull/8590#discussion_r4111303963
##########
plugins/transforms/tableinput/src/main/java/org/apache/hop/pipeline/transforms/tableinput/TableInputMeta.java:
##########
@@ -383,11 +385,22 @@ public void check(
} finally {
db.close();
}
- } else {
+ } else if (!Utils.isEmpty(connection)
Review Comment:
Fixed, but it isn't a duplicate: `HopMetadataPropertyWalker` skipped null
fields, so `CONNECTION_NOT_ASSIGNED` was never reported for an unset connection
and the uncoded error was the only remark. Guarding the `load` alone would have
left it with no remark at all.
The walker can now report unset fields, the checker asks for them, and Table
Input no longer loads an empty name. `null` and `""` each give one
`CONNECTION_NOT_ASSIGNED` warning. Tests added at all three levels; verified in
the GUI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
