bamaer opened a new pull request, #8641: URL: https://github.com/apache/hop/pull/8641
…w actions PDI only began writing the run_configuration element for Job and Transformation entries in version 8, writes it empty when one was never selected, and older files have no element at all. The importer replaced the element only where it already held a name, so those actions came out of the import with none and aborted with "You need to specify a workflow run configuration". The only way out was to open every action in the Hop GUI and press OK. Treat an absent element and an empty one the same way: neither carries a name to preserve, so both get the run configuration given on the command line or in the import dialog, falling back to the 'local' run configuration every Hop project is created with. An action that already names one keeps that name, as of #8516. Mapping and Metadata Injection transforms are left alone because they fall back to a local engine on their own. Covered by unit tests in KettleImportTest and by integration tests 0004 and 0005 in integration-tests/import, the second of which runs the imported workflow to prove all three actions execute. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
