bamaer opened a new pull request, #8661: URL: https://github.com/apache/hop/pull/8661
Add a Signing key column to the PGP encrypt files action, passed to GnuPG as -u, so Sign and Sign and Encrypt rows can name the key that signs instead of taking whatever default-key gpg.conf holds. Sign rows passed the User ID as -r, which GnuPG accepts and ignores for anything but encryption, so the key named there never had any effect. It is now left unused and logged, rather than promoted to the signing key: an existing workflow keeps signing with the same key it always did. Covered by unit tests on the argument list, end-to-end tests against a real gpg with two keys in the keyring, and integration test main-0009, which asserts both the new choice and the unchanged behaviour of rows that name no signing key. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
