mattcasters opened a new pull request, #8696: URL: https://github.com/apache/hop/pull/8696
Add Sequence could only take a typed start, increment, and maximum, or resolve those values from variables. Getting the next number from a preceding max() query meant a second pipeline. With the pipeline counter selected, a configuration transform can now supply those three values from a single row. The hop from that transform is an info hop, so the row is not part of the main stream. Zero rows or more than one row stops the pipeline. The new start, end, and increment fields name the columns on that row. End is the existing maximum: after it, the sequence returns to the start value. Typed counter values stay stored and are not used while a configuration transform is selected. A database sequence ignores the configuration transform, so that hop remains a main input. The dialog shows the four options in the counter group, and the Add Sequence manual page lists them. `./mvnw -pl plugins/transforms/addsequence -am test -Dtest=AddSequenceTest,AddSequenceMetaTest -Dsurefire.failIfNoSpecifiedTests=false` passed (27 tests). The dialog was not opened. fixes #5193 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
