mattcasters opened a new pull request, #8697: URL: https://github.com/apache/hop/pull/8697
The edit dialog for a transform or action that references a pipeline or workflow offered a Browse button. Opening that file was available from the canvas context menu, so a user who opened the dialog from the transform name had to leave the dialog before they could open the referenced file. An Open button now sits beside Browse in Pipeline Executor, Workflow Executor, Simple Mapping, Multi Mapping, Metadata Injection, the Pipeline action, the Workflow action, Repeat, Kafka Consumer, and Azure Event Hubs Listener. Multi Mapping uses its existing Edit button for the same action. When the dialog has unsaved edits, Hop asks whether to save them. Yes applies the dialog the same way OK does and then opens the filename stored on the transform or action. No opens the path currently shown in the field and leaves the dialog open. Cancel leaves the dialog unchanged. A blank filename, or a variable that resolves to a blank path, shows an error and leaves the dialog unchanged. Read-only dialogs open the file without the save question. Pipeline Executor and Workflow Executor disable Open when the filename comes from a field. ReferencedFileOpenerTest covers the save decision, the dirty check, and which filenames can be opened. It passed under `tools/with-isolated-display.sh ./mvnw -pl ui,plugins/transforms/pipelineexecutor,plugins/transforms/workflowexecutor,plugins/transforms/mapping,plugins/transforms/metainject,plugins/actions/pipeline,plugins/actions/workflow,plugins/actions/repeat,plugins/transforms/kafka,plugins/tech/azure -am test -Dtest=ReferencedFileOpenerTest -Dsurefire.failIfNoSpecifiedTests=false -rf :hop-ui` (BUILD SUCCESS). The Hop GUI was not started. fixes #5275 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
