mattcasters opened a new pull request, #8698:
URL: https://github.com/apache/hop/pull/8698
A new data set opened with an empty name, an empty folder, and the
placeholder file `data-set-filename.csv`. The folder field also had no browse
button, so choosing a subfolder of the configured datasets location meant
typing the path.
Creating a data set now suggests `ds-<pipeline file>-<transform>` for the
name and the same text with a `.csv` extension for the base file name. The
pipeline part is the file name of the pipeline open in the explorer, without
its directory or extension. The transform is the one used by Create data set on
the pipeline graph, or the only selected transform when the data set is created
from the metadata perspective. The folder is `${HOP_DATASETS_FOLDER}` when that
variable is set (including on a parent variable space), otherwise the pipeline
directory. Browse... opens in that folder so a subfolder can be selected.
Values that are already set are left unchanged, and a suggested name that
already exists gets a ` 2`, ` 3`, ... suffix. The same dialog is used for input
and golden data sets.
Tested with `./mvnw -pl plugins/misc/testing test
-Dtest=DataSetDefaultsTest,HopGuiDataSetCreateBeforeDialogTest
-Dsurefire.failIfNoSpecifiedTests=false` (14 tests, all passed). The dialog was
not opened in Hop GUI.
fixes #5370
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [x] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
