mattcasters commented on code in PR #8714: URL: https://github.com/apache/hop/pull/8714#discussion_r4153811591
########## docs/hop-dev-manual/modules/ROOT/pages/plugin-types/gui.adoc: ########## @@ -65,7 +65,7 @@ xref:gui-plugins-toolbars.adoc[GUI plugins and toolbars] covers this and the mid == Perspective -A perspective is a full screen in the Hop GUI, selected from the icons in the left sidebar: the Data Orchestration, Metadata, Explorer and Execution Information perspectives are all plugins. +A perspective is a full screen in the Hop GUI, selected from the icons in the left sidebar: the File Explorer, Metadata, Execution Information, Configuration, Database and Plugins perspectives are all plugins. Review Comment: **[nit]** This is presented as the left-sidebar set, but it is not sidebar order and "Plugins" is not the English name. Perspectives are sorted by plugin id: File Explorer (`100-`), Execution Information (`150-`), Configuration (`160-`), Database (`170-`), AI Assistant (`175-`, off by default), Metadata (`200-`), then Plugin explorer (`500-`; `PluginExplorerPerspective.Name` is "Plugin explorer"). The same list was copied to `docs/hop-dev-manual/modules/ROOT/pages/sdk/plugins/perspectives.adoc`. **Suggestion:** List them in id order and use "Plugin explorer", or mark the sentence as examples rather than the sidebar. ########## docs/hop-user-manual/modules/ROOT/pages/hop-gui/perspective-file-explorer.adoc: ########## @@ -24,22 +25,38 @@ Keyboard shortcut: `CTRL-Shift-E` == Description -The file explorer perspective is where you'll perform a lot of your file operation. +The File Explorer perspective is where you'll spend most of your time in Hop Gui. +This is where xref:pipeline/pipelines.adoc[pipelines] and xref:workflow/workflows.adoc[workflows] are built, tested and run, and where you'll perform most of your file operations. + +The project tree on the left shows the files in your project. +Files you open appear as tabs in the editor area next to the tree. This perspective contains handlers for the most common file types known to Hop. These are obviously hwf (workflows) and hpl (pipelines), but also JSON, CSV, TXT, XML, Markdown, SVG, Log and SAS 7 BDAT files. The File Explorer perspective is also where you'll manage version control for your projects through xref:hop-gui/hop-gui-git.adoc[Git integration]. +NOTE: Older Hop versions had a separate Data Orchestration perspective for editing pipelines and workflows. It has been merged into the File Explorer perspective. Review Comment: **[suggestion]** The deleted Data Orchestration page documented `CTRL-Shift-D`. That chord is now the Database perspective (`DatabasePerspective` is control+shift+D, global). Editing stays on `CTRL-Shift-E`, which this page already lists. The alias sends the old page here, so readers who still use D land in Database with no explanation. **Suggestion:** Add that `CTRL-Shift-D` is the Database perspective and that pipeline and workflow editing stays on `CTRL-Shift-E`. ########## docs/hop-user-manual/modules/ROOT/pages/hop-gui/perspective-execution-information.adoc: ########## @@ -176,7 +176,7 @@ image::execution-information-perspective-to-parent-toolbar-icon.png[go to the pa === Edit the pipeline or workflow -If you want to quickly navigate from the execution information of a pipeline or workflow to its editor, you can click on the data orchestration icon in the toolbar: +If you want to quickly navigate from the execution information of a pipeline or workflow to its editor, you can click on the edit (pencil) icon in the toolbar or press `F3`: Review Comment: **[suggestion]** The new wording matches the current toolbar (`ui/images/edit.svg`, shortcut F3, changed from `data_orch.svg` / F5 in #7424), but the screenshot on the next line was not updated. It still circles the old data-orchestration icon, so the sentence and the picture disagree. **Suggestion:** Replace `execution-information-perspective-to-editor-toolbar-icon.png` with a capture of the pencil button, or drop the image until it matches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
