bamaer commented on PR #8743:
URL: https://github.com/apache/hop/pull/8743#issuecomment-6021516320
Thanks for the review. The three points are addressed in the latest commit:
- **SQL-002 row limit:** `NOT_MATCHES_PATTERN` now reads an unset value as
`""` instead of passing it. All other conditions still handle an unset value as
before. The `rowLimit` pattern is now `^\s*([+-]?0*|-\d+)\s*$`, which covers
blank, `0`, `+0`, `-0` and negative limits. `${LIMIT}` is still not reported.
`0k` and `0.000` are not covered: that needs a numeric condition, and SQL-002
is disabled by default. Tests added for an unset limit, `-1` and `+0`.
- **NAMING-004 description:** it now names the plugin name and the numbered
form, e.g. 'Table input' or 'Table input 2'. The manual's rule table is updated
to match. The finding already identifies the transform, so the message itself
is unchanged.
- **IS_EMPTY comment:** replaced with the example from the manual: `url`
`MATCHES_PATTERN ^https://.*` and `httpLogin` `IS_EMPTY`, under `allOf`, report
a plain http:// URL with a login.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
