bamaer commented on PR #8745:
URL: https://github.com/apache/hop/pull/8745#issuecomment-6022894833

   Both addressed in 3d1c8a1598.
   
   **Enabled state on open:** `ConfigPluginOptionsTab` now calls 
`widgetsPopulated` right after `setWidgetsListener`. This is in a small 
`attachWidgetsListener` method, which `ConfigPluginOptionsTabTest` covers. 
"Block Commits on Warnings" is now disabled as soon as the page opens. The 
other config plugins have an empty `widgetsPopulated`, so their pages are 
unchanged.
   
   **Sorting:** `order()` now keeps a cache of the file names it has resolved, 
so each path goes through VFS once per sort and keeps the same key for the 
whole sort. `displayName` wasn't used because it also calls `normalizePath`.
   
   Checked by hand in Hop GUI: the linter options page and sorting the results 
of a 292-file folder.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to