mattcasters opened a new pull request, #8846: URL: https://github.com/apache/hop/pull/8846
Stopping a pipeline calls `Pipeline.stopTransform`, which marks the transform stopped and then calls `stopRunning()`. Table Input and Database Join returned immediately when that flag was already set, so `cancelQuery()` and `cancelStatement()` never ran. The transform stopped emitting rows, but `dispose()` then closed a result set that had only been partly read. The Microsoft SQL Server JDBC driver reads the rest of that result set on close, so the query kept running on the server and the pipeline stayed in Halting until the whole result had been sent. Database Lookup, Dynamic SQL row, Execute SQL script, and Execute row SQL script already cancel without this guard. `isCanceled` still prevents a second cancel, and a disposed transform still returns before it touches the connection. Database Join still takes `dbLock` for the whole lookup, so a cancel waits until the current fetch releases that lock. It does cancel the prepared statement before the next lookup. `TableInputTest` (8) and `DatabaseJoinTest` (5) cover the stop-then-cancel order. The tableinput and databasejoin unit suites passed with `-Pskip-uitest` (49 and 35). The SQL Server measurement from the issue was not repeated here. fixes #8667 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
