hansva opened a new pull request, #8843: URL: https://github.com/apache/hop/pull/8843
Folder turning into a non-existent object: doAttach() now recomputes the key from the file name every time, instead of reusing the key/ a previous attach left behind. % in object names: the bucket and key are taken from the decoded path, so file%25.txt reads the object file%.txt; listings escape % in child names (files, subfolders and bucket names), the same way Commons VFS's own local-file provider does. Error messages: reading a folder or a missing object now raises "not a file" (read-not-file) instead of a generic read error; listing a file now raises "not a folder" (list-children-not-folder) instead of returning an empty list. The shared suite found this extra case once the % failure no longer hid it. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
