Adalennis opened a new pull request, #8957: URL: https://github.com/apache/hop/pull/8957
Fixes #2606 Follow-up to #8949, which added the missing page descriptions. - New step "Check page descriptions" in the docs PR build, next to the cross-manual references check and in the same style: a page under `pages/` without a `:description:` line fails the build with an error annotation on that file. `pages/snippets` is skipped, since those files are only included by other pages. - The five `hop-tools/hop-conf/hop-conf-*.adoc` include fragments moved to `pages/snippets/hop-tools/hop-conf/`, where the other fragments live, so the check skips them. Their six `include::` lines are updated; `hop-conf.adoc` and `projects/advanced.adoc` render the same text as before. Tested locally on macOS and in an Ubuntu container (GNU grep, as on `ubuntu-latest`): the step passes on main with this change, fails when a description is removed from a page, and on main before #8949 it reports the 67 pages that had none. actionlint and shellcheck report nothing. - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
