mattcasters opened a new pull request, #8999: URL: https://github.com/apache/hop/pull/8999
The client assembly was shipping two versions of several libraries. `hop-core`, the RCP fragment, and the Google technology plugin each copy runtime jars into `lib/core`, and the fake and phone transforms each carried their own `libphonenumber`. Whichever copy a classloader saw first won. The root POM now pins one version, and the modules that were forcing an older copy use that pin: - `api-common` 2.62.0 - `proto-google-common-protos` 2.70.0 - `google-auth-library-credentials` and `google-auth-library-oauth2-http` 1.46.0 (the Beam engine no longer forces 1.30.0) - `error_prone_annotations` 2.50.0 - `animal-sniffer-annotations` 1.27 - `stax2-api` 4.3.0 (the XML transform no longer forces 4.2.2) - `libphonenumber` 9.0.40 - `icu4j` 78.3 Graal's shaded `org.graalvm.shadowed:icu4j` and `org.graalvm.shadowed:xz` stay in the script plugin. Their classes live under `org.graalvm.shadowed`, so they are separate libraries from IBM ICU and Tukaani xz. `tools/check-assembly-jar-versions.py` reads the client zip (or an unpacked assembly directory) and exits 1 when one library is present at two versions. It is not wired into CI. Verification: - Reactor `dependency:tree` shows one version of each pinned library. - Packaged the core, UI, engine, RCP, Google, Beam, and the fake, script, phone, and XML transforms. The checker reports no mismatches on the jars that make up the default client. - `tools/check-assembly-jar-versions.py --self-test` passed. - `./mvnw -N apache-rat:check` and Spotless on the root POM passed. A full `mvn clean install` was not run. fixes #8998 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
