bamaer commented on PR #8999: URL: https://github.com/apache/hop/pull/8999#issuecomment-6249122286
@mattcasters thanks, this clears all of #8998. Built main and this PR locally and ran `tools/check-assembly-jar-versions.py` on both: | client zip | main | PR | |---|---|---| | default | 8 libraries at 2+ versions | none | | `-Pbeam` | 15 | 6 | The older copies are the only jars that disappear, and icu4j (78.1 → 78.3) and fake's libphonenumber (9.0.23 → 9.0.40) are the only versions that change. Unit tests of beam, google, fake, script and standardizephonenumber pass; the xml, beam_directrunner and fake/phone ITs show no new failures compared to main. The 6 left in the `-Pbeam` client are already on main: failureaccess, jaxb-api, jcl-over-slf4j and snappy-java in `lib/core`, plus azure-storage (azure plugin) and xbean-asm9-shaded (janino plugin) overriding `lib/core`. That's for a follow-up, not this PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
