bamaer commented on PR #9006: URL: https://github.com/apache/hop/pull/9006#issuecomment-6249537610
Thanks @Adalennis, this is a big improvement: the page now actually explains how to create a project. Docs-only, so nothing here can break anything. **Fix before merge** - **"Create a project" fails unless the home folder already exists** (`hop-conf-projects.adoc`, "Create a project"). `hop-conf.sh --project-create --project=sales --project-home=/data/projects/sales` stops with `Project 'sales' home folder '/data/projects/sales' does not exist`. Suggested fix: add `mkdir -p /data/projects/sales` to the example, or one line saying the home folder has to exist first. **Worth fixing** - **`-fj` / `--generate-fat-jar` was dropped from the Options table.** At least seven other pages (Beam, Flink, Spark, Databricks, lakehouse) tell readers to run `hop-conf.sh -fj` or `--generate-fat-jar`, and this page no longer mentions it. Suggested fix: add it back as a row (or as a short "Fat jar" line next to the cloud sections). Verified: I ran every project, environment, config-file and `-sv`/`-dv` example on a current 2.20.0-SNAPSHOT client, with all five `--project-variables` quoting rows typed in bash. Apart from the item above, the outputs and the resulting JSON match the page. I also checked the Options table against the `@Option` definitions on `main`, and rendered both pages with Asciidoctor: the heading levels are right and there are no section-out-of-sequence warnings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
