bamaer commented on PR #9051:
URL: https://github.com/apache/hop/pull/9051#issuecomment-6307994120
Thanks @mattcasters, the connection fallback (selected → active editor →
only one → ask) is a nice touch.
Built `ui` with `-am` (checkstyle and spotless clean) and ran the four test
classes: 13 pass. Code reviewed, not run in the GUI.
**Should fix**
- `HopGuiAuditDelegate.openInLastFiles` skips any File Explorer entry whose
path is also open in a Database SQL editor, and keeps doing that on every
startup. With this PR you can open `load.sql` in both perspectives on purpose
(Database active, then Explorer active). After a restart the Explorer tab is
gone. The test asserts exactly that: `openInLastFiles("SQL
File\u0001/tmp/load.sql", Set.of("/tmp/load.sql"))` is `false`.
Suggestion: make the clean-up one-shot. Only skip Explorer copies of paths
that still have a legacy `Database SQL\u0001…` entry in the
`database-perspective` list. Since `writeLastOpenFiles` no longer writes those
entries, the filter stops applying after the first save.
Nothing blocking from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
