gvdutra opened a new pull request, #9193: URL: https://github.com/apache/hop/pull/9193
Fixes #9045. Treat Unicode space characters such as non-breaking spaces as spaces in Hop's shared trim helpers. This makes JSON Input and other value conversions honor left, right, and both trim settings for these characters while leaving trim-none unchanged. Added coverage for all four trim modes and an end-to-end JSON Input regression test. Tests: - `./mvnw -pl core test` (1,900 tests) - `tools/with-isolated-display.sh ./mvnw -pl plugins/transforms/json -am -Dtest=JsonInputTest#testTrimNonBreakingSpaces -Dsurefire.failIfNoSpecifiedTests=false test` - `./mvnw -pl core,plugins/transforms/json spotless:apply spotless:check` ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
