Adalennis opened a new pull request, #9217: URL: https://github.com/apache/hop/pull/9217
Fixes #8970 Fourteenth and last batch: a Result section on the pages of MongoDB QL, Build documentation, Databricks job wait, Snowflake warehouse manager and AS/400 command. With batches 12 and 13 (#9197, #9200) every workflow action page has a Result section. MongoDB QL and Build documentation were tested with hop-run against the current code (41 workflows: MongoDB 7 in Docker, emptied before each test and queried afterwards; small projects for Build documentation, one of them with a broken pipeline file). The October 21 snapshot has no documentation and MongoDB plugins, so they were compiled from upstream/main (no changes to these actions since). Each action was also run after an action that is true with 2 errors and after a false action, and with a previous result holding files and rows. Databricks job wait, Snowflake warehouse manager and AS/400 command were NOT tested: there was no Databricks workspace, Snowflake account or IBM i system available. Their Result sections are written from execute() and the helpers it calls, so they deserve a check by someone who can run them. What the tests show: - Build documentation never sets its own result: on success it passes on the result of the previous action. After a false action on an unconditional or failure hop it is false, although the documentation was written (the same kind of issue as Repeat in #9132). Documented as a WARNING. A project file that can't be read (a pipeline that isn't valid XML) gives false and leaves the documentation incomplete. Files already in the target folder stay. - Build documentation: the section about generating HTML with pandoc was outdated. Generate HTML? writes an HTML file next to each MarkDown file and the HTML index links to them; Remove MarkDown files? only works together with Generate HTML?. - MongoDB QL: the page said several instructions can be separated by commas. Without the brackets of a JSON array only the first instruction runs, without an error. Fixed in the option description and documented in a NOTE. - MongoDB QL is true when MongoDB reports write errors in its answer: an insert with a duplicate _id is true although the duplicate is not inserted. In an array the instructions before a failing one stay done, the ones after it are not run. From the code: - Snowflake warehouse manager never sets the number of errors: it is false with 0 errors. Create and Alter use the warehouse name without resolving variables; Drop, Resume and Suspend resolve them. - Databricks job wait: "Cancel Databricks run if workflow is stopped" also cancels the run when the timeout is reached; the error variable stays empty for a canceled run. - AS/400 command: false with 1 error when the server, the login or the command fails; the messages of a failing command are logged. Also fixed labels: Timeout (seconds, 0=none) and Cancel Databricks run if workflow is stopped (Databricks job wait); Replace, Fail if warehouse exists, Fail if warehouse does not exist, Warehouse size, Warehouse type, Auto suspend (minutes), Auto resume, Initially suspended (Snowflake warehouse manager); Host name and Port of the proxy (AS/400 command); the option names of Build documentation. Found while testing (not reported yet): Build documentation keeping the previous result, MongoDB QL running only the first comma-separated instruction and being true on write errors; from the code, Snowflake warehouse manager being false with 0 errors and not resolving variables in Create and Alter, and Databricks job wait canceling the run on a timeout. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
