bamaer commented on PR #9334: URL: https://github.com/apache/hop/pull/9334#issuecomment-6693661378
Thanks @hansva, LGTM. Verified locally: built `core` from the PR head and ran `ResultTest` (7/7) and `RowMetaAndDataTest` (5/5). With main's `Result.java`, three of the new tests fail as expected. A 200k-row clone with date/number masks gives the same metadata and values as the old per-row clone, in 11 ms instead of 530 ms. No code in the repo changes a result row's metadata in place, so sharing one metadata clone across rows inside a clone has no visible effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
