bamaer commented on PR #9241: URL: https://github.com/apache/hop/pull/9241#issuecomment-6627362041
Thanks @Adalennis, 17d9bfa addresses all of the points: 1. The new "Version attributes" section in `writing-documentation.adoc`, the pom comments and the release-step check cover keeping the attributes in sync. 2. The dev manual keeps only `java-version`. 3. The cluster walkthrough is back to `SPARK_VERSION=4.1.3`, which matches the compose file. 4. The Docker JRE is named in the `target.jdk.version` comment and in the new section. 5. The Hop Web sentence now reads "This version of Hop". 6. Leaving the Debezium line as it is is fine. 7. All five values are quoted. The only thing left is CI: `build` runs `spotless:check` with sortPom, which has to accept the new pom comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
