bamaer commented on PR #9357:
URL: https://github.com/apache/hop/pull/9357#issuecomment-6703981242

   Thanks @leehaut, this works as described: both new tests fail on main and 
pass on this branch, and the module tests are green.
   
   **Blockers**
   
   - **Add filenames: a file entry with a non-regex wildcard now fails.** 
`compileWildcard()` runs before the file/folder check 
(`ActionAddResultFilenames.java:180`). The wildcard only applies to folders, 
but a single file `a.txt` with wildcard `*.txt` now gives `result=false, 
errors=1, files=0`; on main it gives `true, 0, 1`. This can also happen with 
*Copy previous results to args?*, where the wildcard comes from the second 
field of the row.
     Suggested fix: compile it only in the folder branch, as Delete files does: 
`addMatchingFilesFromFolder(filefolder, compileWildcard(realWildcard), 
parentWorkflow, result)`. Then limit the docs line to folders ("…and the 
*Wildcard (RegExp)* of every folder is a valid regular expression").
   
   Built and ran the unit tests of both plugins locally; not run in a workflow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to