leehaut opened a new pull request, #9357: URL: https://github.com/apache/hop/pull/9357
Fix https://github.com/apache/hop/issues/9264 ## Summary - **Add filenames to result:** compile the wildcard RegExp once before selecting files. An invalid expression (e.g. `([`) now fails the entry instead of being caught per file, leaving the action successful with zero result files. - **Delete folders:** align `When number of errors less than` with Move files (#9175): success requires strictly fewer errors than the limit (`nrErrors < limit`). Reaching the limit on the last entry no longer leaves the action true while the same count earlier in the list made it false. - Update the action docs that previously documented these behaviours as NOTES. - Add unit tests for both cases. ## Test plan - [x] Manual: invalid RegExp on Add filenames to result → `result=[false]` - [x] Manual: Delete folders, limit=1, order folder then file → `result=[false]` - [x] Manual: Delete folders, limit=1, order file then folder → `result=[false]`, remaining folder kept - [x] Unit: `ActionAddResultFilenamesResultTest` - [x] Unit: `ActionDeleteFoldersResultTest` - [x] `./mvnw spotless:apply` / CI `spotless:check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
