leehaut opened a new pull request, #9326:
URL: https://github.com/apache/hop/pull/9326

   Fix https://github.com/apache/hop/issues/9316
   
   ## Summary
   - On a case-insensitive disk, renaming `data.csv` to `Data.csv` in the VFS 
File Explorer failed with "already exists". The destination exists because it 
is the same file, and the check compared the path case-sensitively.
   - The rename now treats two local paths with the same canonical path as one 
file, then uses the existing `moveTo()`. Copy, move, and download still use the 
case-sensitive comparison.
   - Renaming onto a different existing file is still refused.
   
   ## Test plan
   - [x] On Windows, rename `data.csv` to `Data.csv` in the VFS File Explorer. 
The file is renamed and its content is unchanged.
   - [x] Rename a file to the name of a different file that already exists. The 
explorer still reports that the name already exists.
   - [x] On a case-sensitive volume, rename `data.csv` to `Data.csv` when no 
`Data.csv` exists. The rename succeeds.
   - [x] `VfsFileTransferTest.aCaseOnlyLocalNameIsTheSameFile` passes on both 
case-insensitive and case-sensitive disks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to