bamaer opened a new pull request, #9372:
URL: https://github.com/apache/hop/pull/9372

   …rent folder" is off
   
   Fixes #9356.
   
   `SurefireReportWriter` always created the folder of the report file, so 
"Create parent folder" had no effect. The writer no longer creates folders. 
With the option off and the folder missing, the transform now fails with a 
message naming the folder and pointing to the option.
   
   Tests: new `SurefireReportOutputTest` covers a missing folder with the 
option off and on, and an existing folder with the option off. 
`SurefireReportWriterTest` gets a test that the writer creates no folder. Both 
new tests fail without the fix.
   
   Behaviour change: pipelines that have the option off and relied on the 
folder being created will now fail. The option is on by default, and the IT 
runner and the sample both keep it on.
   
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to