Adalennis opened a new issue, #9406:
URL: https://github.com/apache/hop/issues/9406

   ### Apache Hop version?
   
   2.20.0
   
   ### Java version?
   
   Java 21
   
   ### Operating system
   
   macOS
   
   ### What happened?
   
   These samples fail when run from the samples project of a standard 2.20.0 
installation, also when their note is followed. They are unchanged on main.
   
   | Sample | Problem |
   |---|---|
   | `transforms/dataset-input.hpl` | Reads the data set `golden-data-stream`, 
which only exists in the integration-tests project. The note says "Create a 
data set named 0108-data-set-output before running", which is not the data set 
the transform reads. |
   | `transforms/dataset-output.hpl` | Writes to the data set 
`0108-data-set-output`, also from the integration tests. It fails with "Data 
set '0108-data-set-output' could not be found in the metadata", and the note 
doesn't mention it has to exist. |
   | `transforms/execute-unit-tests.hpl` | Runs the unit test 
`sample-unit-test`, which doesn't exist anywhere. The samples project has 
`run-pipeline-tests-unit` and `mapping-use-unit`. |
   | `transforms/execution-information.hpl` | Uses the execution information 
location `local`, but the samples project has no execution information location 
at all. The transform also uses "Get execution IDs" without the "Include 
children" and "Limit" fields, which the operation requires (the transform page 
says so), so it fails before it gets to the location. |
   | `transforms/data-stream-input.hpl`, `transforms/data-stream-output.hpl` | 
Use the data stream `sample-data-stream`. Its metadata and every data stream 
type are in the Apache Arrow plugin, which is installed from the marketplace, 
while the Data stream transforms and these samples ship in the standard client. 
They fail with "Unable to find data stream metadata element: 
sample-data-stream". |
   
   Suggestions:
   - Point the testing samples at the data sets and unit test the samples 
project already has (`run-pipeline-tests-input`, `run-pipeline-tests-golden`, 
`run-pipeline-tests-unit`), or add the metadata they use, and fix the note of 
`dataset-input.hpl`.
   - Add an execution information location `local` to the samples metadata, and 
the two input fields to `execution-information.hpl`.
   - Move the data stream samples to the Apache Arrow plugin, or say in their 
note that they need it.
   
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Samples


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to