bamaer commented on PR #9401: URL: https://github.com/apache/hop/pull/9401#issuecomment-6772518721
Thanks @rmannibucau, the split makes this much easier to review. We read the code, built the PR and ran `PipelineTest` and `BaseTransformTest` (43 tests, all pass). With `Pipeline.java` and `BaseTransform.java` reverted to main, 5 of the new tests fail, including both deadlock tests, so they cover the fix. We have not run the integration tests. **Blockers** None. **Should fix** - **Integration test for error shutdown.** This changes how every local pipeline stops, and only unit tests cover it. Please add a pipeline to `integration-tests/database`, for example `0049-execute-sql-row-error-stops-pipeline.hpl`. It should run Table Input (a few thousand rows) → Filter rows → Execute SQL row, where the SQL fails on one row and there is no error hop. Call it from a workflow that expects the pipeline to fail, the same way `main-0007-input-lookup.hwf` handles `0007-database-lookup-should-fail.hpl`. The workflow must finish with the failure result and must not hang. It won't reproduce the race every time, but it covers the shutdown path from #9399 end to end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
