leehaut opened a new pull request, #9415:
URL: https://github.com/apache/hop/pull/9415

   Fix https://github.com/apache/hop/issues/9414
   
   
   Hop renders every bundle string through `java.text.MessageFormat`. Several 
translations, and the English Native Spark tooltips, contain patterns that fail 
while the pattern is parsed. `GlobalMessageUtil` logs `Format problem with 
key=...` and drops the translation.
   
   Starting Hop GUI in `zh_CN` hits this while GUI menu plugins are registered:
   
   `DatabaseExplorerDialog.Menu.SQLSelect` was ` {{0}} `, which makes 
`MessageFormat` try to parse `{0}` as an argument index (`can't parse argument 
number: {0}`). The English label is the static text "Generate SQL Select...". 
That menu label is resolved once at plugin init with no arguments, so the 
Chinese Database Explorer menu labels are aligned with the English text and no 
longer contain `{0}`.
   
   The same scan of `messages_*.properties` found the same failure in `pt_BR`, 
`ko_KR`, `it_IT`, `de_DE`, `pl_PL`, `es_ES`, and `en_US`. Each value is 
corrected to a pattern `MessageFormat` accepts:
   
   - Close or reorder braces so placeholders match the English `{0}`, `{1}`, 
`{2}`, `{3}` arguments.
   - Quote literal variables as `'${NAME}'` / `'${...}'`, which is what Hop 
shows after formatting. This covers the Native Spark tooltips 
(`${PROJECT_HOME}`, `${...}`) and the Spanish pipeline performance tooltip.
   - Restore the Portuguese Spark placeholders to `${PROJECT_HOME}`, 
`HOP_DATA`, and `OUTPUT_ROOT`.
   - Repair the Portuguese marketplace URL-template tooltip so `${groupId}`, 
`${groupPath}`, `${artifactId}`, and `${version}` survive formatting.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to