bamaer commented on code in PR #9485: URL: https://github.com/apache/hop/pull/9485#discussion_r4573902046
########## docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/azure-event-hubs-writer.adoc: ########## @@ -38,3 +38,7 @@ This needs to be a policy with the "Send" claim enabled. * Message field: the field containing the message to use as the events. Please note you can use a transform like JSON Output or "Java Script" to assemble the message. +== Samples + +The samples project has `transforms/azure-event-hubs-writer.hpl`, which writes the two rows of a Data grid to an event hub. +Fill in the Event Hubs connection settings before you run it. Review Comment: The sample has no Message field set. If you fill in only the connection settings, the first row fails with `Unable to find field 'null' in the Transform input` (`AzureWrite.java:97-100`). Either set `name` as the Message field in the sample (this would fit in #9487), or extend the sentence: "Fill in the Event Hubs connection settings and choose `id` or `name` as the Message field before you run it." The transform sends one field per row, so "sends one event per row of a Data grid" describes it more accurately than "writes the two rows". ########## docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/calldbproc.adoc: ########## @@ -78,4 +78,9 @@ This tab is available when the result type is *Row*. The listed columns are appe |Format|Optional conversion mask. |Length|Field length. Empty means unspecified. |Precision|Field precision. Empty means unspecified. -|=== \ No newline at end of file +|=== + +== Samples + +The samples project has `transforms/call-db-procedure.hpl`, which calls the `addCount` procedure for two rows through the `hop-samples` connection. +That H2 database has no such procedure: set a procedure of your own database before you run it. Review Comment: #9487 changes this sample to call H2's `LENGTH` instead of `addCount`, so after it merges these two lines will be wrong. #9487 also fixes the CRC32 sample that this PR leaves off the Add checksum page. Whichever of the two PRs merges second should update both pages. The simplest option may be to move the Call DB procedure page and the CRC32 line into #9487. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
