leehaut opened a new pull request, #9498:
URL: https://github.com/apache/hop/pull/9498

   Fix https://github.com/apache/hop/issues/9497
   
   ## Summary
   
   `org.apache.hop.core.Result.getResult()` has been deprecated since 2.16 in 
favor of `isResult()`. Both methods read the same success flag, so this change 
does not alter execution behavior.
   
   - Call sites whose receiver is `org.apache.hop.core.Result` now use 
`isResult()`. This covers production code (`LineageRunLifecycleEmitter`, 
`LoadBalancingWorkflowEngine`, `CypherScript`, 
`WorkflowReplayGateAfterActionXp`) and the action tests that assert on 
`execute(...)`.
   - `Result.getResult()` stays, marked `@Deprecated(since = "2.16")`, and 
delegates to `isResult()` so external plugins keep compiling. It has to be a 
real method: with `getResult()` present, Lombok treats it as the getter for 
`boolean result` and does not generate `isResult()`.
   - Plain accessors that duplicated `@Getter` / `@Setter` are removed: 
`getRows()`, and the get/set pair for bytes read and written by the current 
action. `setRows()` stays, because a `null` argument is stored as an empty list.
   - `ResultTest` covers the default flag, `setResult`, agreement between 
`isResult()` and the deprecated `getResult()`, `clone` / `lightClone`, the XML 
round trip, and the `"result"` JSON property.
   
   Methods named `getResult()` that return a `Result` object are unchanged. 
That includes `Workflow.getResult()`, `Pipeline.getResult()`, 
`ActionResult.getResult()`, and `WebResult.getResult()`.
   
   
   ## Test plan
   
   - [x] `./mvnw -pl core test -Dtest=ResultTest`
   - [x] Run a touched action test module, for example `plugins/actions/http` 
or `plugins/misc/mail`, and confirm success and failure assertions still match 
the action outcome
   - [x] Compile the touched modules and confirm there is no deprecation 
warning for `org.apache.hop.core.Result.getResult()` at the updated call sites
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to