bamaer opened a new issue, #9515:
URL: https://github.com/apache/hop/issues/9515

   ### What would you like to happen?
   
   The XML Join dialog works, but it is hard to use:
   
   - Target, source and comparison fields are free-text boxes. Nothing lists 
the fields of the selected transform, so a typo only shows up at runtime as 
"field not found".
   - No field has a tooltip. Target vs. source and the `?` placeholder for 
complex joins are only explained in the docs.
   - The layout is hand-built: rows are attached to widgets in other groups, 
the last group is stretched to a fixed offset, and widgets end at different 
right edges.
   
   Proposal:
   
   - Rebuild the dialog from `@GuiWidgetElement` annotations on `XmlJoinMeta`, 
in grouped boxes (target document, source elements, join, output). It resizes 
cleanly and keeps OK/Cancel at the bottom.
   - Turn the field boxes into combos that list the output fields of the 
selected transform and refresh when it changes. Variables keep working.
   - Enable the comparison field only for complex joins.
   - Add a tooltip to every option and update the XML Join docs page.
   
   Tests: a SWTBot dialog test (round-trip of the existing XML Join IT 
transforms, edits, cancel, layout), written and run against the current dialog 
first, plus an IT for the options that have no end-to-end coverage yet (omit 
null values, blank encoding, variables in the XPath and comparison field).
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Transforms, Component: Hop Gui
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to