alexander-schneider opened a new issue, #9532:
URL: https://github.com/apache/hop/issues/9532

   ### What would you like to happen?
   
   Would an optional sample showing how to ingest Adanos sentiment snapshots be 
welcome in the Samples project? I work on Adanos and am asking for agreement on 
scope and placement before implementation, following the [code contribution 
guide](https://hop.apache.org/community/contribution-guides/code-contribution-guide/).
   
   The smallest proposed contribution reuses the existing 
[tap-adanos](https://github.com/adanos-software/tap-adanos/tree/970c6a95d4548b815c1bd57643e463d910ab752a)
 rather than adding a Java connector or an API client to Hop:
   
   - A pipeline reads saved Singer JSON Lines with Text file input, parses each 
message with JSON Input, filters for `RECORD` messages from `asset_sentiment`, 
then extracts selected `record` fields. SCHEMA/STATE messages are not data rows.
   - A small synthetic fixture runs offline without a key. Proposed placement 
is 
`plugins/transforms/json/src/main/samples/transforms/json-input-adanos-snapshot.hpl`,
 with input under `transforms/files/`, following the plugin-samples guide. An 
AsciiDoc note and a canvas note explain extraction and running the sample.
   - Optional extraction instructions use the customer's own key via 
`TAP_ADANOS_API_KEY`, never a committed key or command-line secret, and 
explicitly set `base_url` to `https://api.adanos.com`. Access to this 
commercial service is optional; source access, history/lookback and request 
quotas depend on the customer's plan.
   - Tap `start_date`/`end_date` map to inclusive UTC API `from`/`to`, not 
deprecated `days`. Stock source choices are `reddit`, `x`, `news`, and 
`polymarket`; crypto currently uses Reddit. The tap has four snapshot streams 
(`asset_sentiment`, `trending_assets`, `asset_comparison`, `market_sentiment`), 
not every API endpoint. This sample would consume only the first.
   - Preserve source, asset and requested-window fields. These are 
extraction-time snapshots, not historical known-at observations; the tap has no 
`observed_at`. No trading logic or price-provider changes.
   
   After agreement, validation would run the actual Hop pipeline against mixed 
Singer messages, checking row counts, values, null handling and malformed-input 
failure, plus the applicable formatting, documentation and license checks. 
There would be no live-key requirement in automated tests.
   
   Is this scope and placement appropriate, and is a committer willing to 
review it? No implementation PR has been opened.
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Samples
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to