nadment opened a new issue, #9534:
URL: https://github.com/apache/hop/issues/9534

   ### Apache Hop version?
   
   SNAPSHOT-20261116 (2.21.0-SNAPSHOT)
   
   ### Java version?
   
   21.0.10
   
   ### Operating system
   
   Windows
   
   ### What happened?
   
   When a Git operation over HTTPS (fetch, pull, push) fails because the 
username or password is wrong, the Git plugin may never ask for credentials 
again. Every later operation sends the same refused credentials, and the only 
way out is to restart Hop.
   
   **Steps to reproduce**
   1. Open a project in a Git repository whose remote is an HTTPS URL that 
requires authentication.
   2. Fetch, pull or push, and enter a wrong username or password in the 
credentials dialog.
   3. Fetch, pull or push again.
   
   **Expected:** Hop asks for the username and password again.
   **Actual:** if the server answers HTTP 403 to the refused credentials 
(GitLab does after a few failed attempts, and so does a server where the 
account has no access to the repository), JGit reports `git-upload-pack not 
permitted on '…'`. The dialog never opens again and the same error comes back 
on every operation until Hop is restarted.
   
   **Cause**
   - `UIGit` only treats the JGit messages `not authorized` and `Authentication 
is required but no CredentialsProvider has been registered` as authentication 
failures. The 403 message (`… not permitted on …`) is not one of them.
   - The refused credentials stay in the `UIGit` instance that `GitGuiPlugin` 
keeps for the whole session.
   - Cloning a repository also asks for the credentials only once: after a 
second refusal it no longer asks.
   
   **Proposed fix**
   - Recognise the 403 message as an authentication failure.
   - Forget refused credentials on every authentication failure, so the next 
operation asks again, even when the user cancelled the dialog or the failure 
came from the automatic fetch.
   - Unit tests with a local HTTP server that answers 401 or 403.
   
   While at it, the title and labels of the shared 
`EnterUsernamePasswordDialog` were hard-coded in English; they are now 
translated.
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: Git, Component: Hop Gui
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to