bamaer commented on code in PR #9535:
URL: https://github.com/apache/hop/pull/9535#discussion_r4596888164


##########
plugins/tech/azure/src/main/resources/azure-storage.svg:
##########
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 18 18">

Review Comment:
   **Blocker**
   
   This is Microsoft's "Storage Accounts (Classic)" icon from the Azure 
architecture icon set: same paths and colours as `Icon-storage-87` in 
`Azure_Public_Service_Icons_V25.zip`. Microsoft's [icon 
terms](https://learn.microsoft.com/en-us/azure/architecture/icons/) allow these 
icons only in "architectural diagrams, training materials, or documentation" 
and reserve all other rights, so it can't ship in an Apache release.
   
   Suggested fix: `image = "azure.svg"` (the Azure logo the plugin already 
ships), or a self-drawn storage icon.



##########
ui/src/main/resources/ui/images/globe.svg:
##########
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 100 100">

Review Comment:
   **Blocker**
   
   This is `globe` from Jean-Marc Viglino's font-gis set (identical path data), 
licensed CC BY 4.0. The ASF [puts CC BY content in Category 
B](https://www.apache.org/legal/resolved.html): attributed, and included in 
binary form only. So it can't sit in the source tree as an SVG.
   
   Suggested fix: a self-drawn globe, or one from an Apache 2.0 set such as 
Material Symbols `language`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to